Skip to content

feat: migrate slot usages #13500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 4, 2024
Merged

feat: migrate slot usages #13500

merged 3 commits into from
Oct 4, 2024

Conversation

@dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Oct 4, 2024

Now that snippets can fill slots, we can add logic to migrate slot usages

There's some cases where it doesn't look as nice due to indentation but I'm not sure how much time we should invest in that

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@dummdidumm
feat: migrate slot usages
85b5490 
Now that snippets can fill slots, we can add logic to migrate slot usages
@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 7e0c70d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

trueadm
trueadm approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me.

trueadm
trueadm reviewed Oct 4, 2024
View reviewed changes
@dummdidumm dummdidumm merged commit 687d9db into main Oct 4, 2024
@dummdidumm dummdidumm deleted the migrate-slot-usages branch October 4, 2024 20:52
@github-actions github-actions bot mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trueadm trueadm trueadm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dummdidumm @trueadm